You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Siddharth Seth (Created) (JIRA)" <ji...@apache.org> on 2011/12/01 02:15:39 UTC
[jira] [Created] (MAPREDUCE-3489) Unit tests failing silently
Unit tests failing silently
---------------------------
Key: MAPREDUCE-3489
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2
Affects Versions: 0.23.0
Reporter: Siddharth Seth
Priority: Critical
If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
TestTaskAttempt is currently running like this.
Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Sharad Agarwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189610#comment-13189610 ]
Sharad Agarwal commented on MAPREDUCE-3489:
-------------------------------------------
let me take a stab at this.
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Sharad Agarwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194633#comment-13194633 ]
Sharad Agarwal commented on MAPREDUCE-3489:
-------------------------------------------
Currently in the AsyncDispatcher, exitOnDispatchException defaults to false. The daemon don't set it to true either. Is this the intended bahaviour ? I think daemons should exit on dispatcher error while testcases can handle it differently. right ?
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-3489:
-----------------------------------------------
Summary: EventDispatcher should have a call-back on errors for aiding tests (was: Unit tests failing silently)
The issue of failing silently should be fixed after MAPREDUCE-3634. There, I have changed the behavior of crashing dispatcher during tests to instead throw exceptions. We will still need some kind of a call-back so that tests can fail better. Currently all tests take care of this by explicit checks and timeouts.
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Vinod Kumar Vavilapalli (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-3489:
-----------------------------------------------
Priority: Minor (was: Major)
bq. Is this jira still an issue?
Yes, it is. But it's minor.
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
> Priority: Minor
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Vinod Kumar Vavilapalli (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190062#comment-13190062 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-3489:
----------------------------------------------------
bq. let me take a stab at this.
Great, thanks!
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Vinod Kumar Vavilapalli (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195103#comment-13195103 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-3489:
----------------------------------------------------
bq. Currently in the AsyncDispatcher, exitOnDispatchException defaults to false. The daemon don't set it to true either.
That is done as part of MAPREDUCE-3634 which isn't committed yet. Appreciate a quick review there ;)
You can develop your patch over MAPREDUCE-3634.
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) Unit tests failing silently
Posted by "Sharad Agarwal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160716#comment-13160716 ]
Sharad Agarwal commented on MAPREDUCE-3489:
-------------------------------------------
Definately System.exit is not the right thing in a library. Sigh! I knew that when I wrote that and intended to remove it. Couldn't get chance to get to it.
I think we should get rid of it and instead have a error handling callback registered to Dispatcher.
> Unit tests failing silently
> ---------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Priority: Critical
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3489) Unit tests failing silently
Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated MAPREDUCE-3489:
-------------------------------------
Priority: Major (was: Critical)
> Unit tests failing silently
> ---------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Amol Kekre (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216042#comment-13216042 ]
Amol Kekre commented on MAPREDUCE-3489:
---------------------------------------
Is this jira still an issue?
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-3489) EventDispatcher should have a
call-back on errors for aiding tests
Posted by "Sharad Agarwal (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal reassigned MAPREDUCE-3489:
-----------------------------------------
Assignee: Sharad Agarwal
> EventDispatcher should have a call-back on errors for aiding tests
> ------------------------------------------------------------------
>
> Key: MAPREDUCE-3489
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3489
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Sharad Agarwal
>
> If one of the dispatched events generates an exception - the dispatcher kills the JVM via a System.exit. Unit tests end up not running - but they don't fail either.
> TestTaskAttempt is currently running like this.
> Previously - have seen TestRecovery and TestJobHistoryParsing do the same. Most of the tests would need to be looked at.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira