You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/05 02:43:21 UTC

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2628: [Engine][Task] Move SourceSplitEnumeratorTask to worker node

EricJoy2048 commented on code in PR #2628:
URL: https://github.com/apache/incubator-seatunnel/pull/2628#discussion_r962434597


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/scheduler/JobScheduler.java:
##########
@@ -17,6 +17,10 @@
 
 package org.apache.seatunnel.engine.server.scheduler;
 
+import com.hazelcast.cluster.Address;
+
 public interface JobScheduler {
     void startScheduling();
+
+    Address queryTaskGroupAddress(long taskGroupId);

Review Comment:
   Please don't save TaskGroup address from scheduler, because scheduler will never use when all of the tasks deploy complete. If Master Node done and another Master Node active, the running job will not be scheduled again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org