[GitHub] [kylin] zzcclp commented on a change in pull request #1481: KYLIN-4813 Refactor spark build log

[GitBox <gi...@apache.org>]

zzcclp commented on a change in pull request #1481:
URL: https://github.com/apache/kylin/pull/1481#discussion_r526552939



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2803,10 +2822,15 @@ public boolean isSparkEngineEnabled() {
         return Boolean.parseBoolean(getOptional("kylin.query.spark-engine.enabled", "true"));
     }
 
-    public String getLogSparkPropertiesFile() {
-        return getLogPropertyFile("kylin-parquet-log4j.properties");
+    public String getLogSparkDriverPropertiesFile() {
+        return getLogPropertyFile("spark-driver-log4j.properties");
+    }
+
+    public String getLogSparkExecutorPropertiesFile() {
+        return getLogPropertyFile("spark-executor-log4j.properties");
     }
 
+

Review comment:
       remove this blank line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org