You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/26 04:10:58 UTC

[GitHub] [kafka] justinrlee opened a new pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

justinrlee opened a new pull request #11811:
URL: https://github.com/apache/kafka/pull/11811


   Single-line change to `build.gradle` to render javadocs for new `org.apache.kafka.common.security.oauthbearer.secured` package (part of [KIP-768](https://issues.apache.org/jira/browse/KAFKA-13202))
   
   cc @junrao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057275446


   @justinrlee : It doesn't seem other PRs have similar problems. Could you trigger another build by adding some minor changes to the PR (e.g. white space) to see if they are transient?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kirktrue commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
kirktrue commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063442392


   I have filed KAFKA-13725 to address the package layout bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] justinrlee commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
justinrlee commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1051595309


   (Also, I'm not sure if we'd want a similar PR to the 3.1 branch)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057262679


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao merged pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao merged pull request #11811:
URL: https://github.com/apache/kafka/pull/11811


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] justinrlee commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
justinrlee commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1055418346


   I'm really not sure, have never done this before.  When I do the build locally, I get a bunch of what look like completely test failures.  I'm not sure how my PR would cause those failures but I don't know enough to troubleshoot, tbh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063288699


   @kirktrue : We could just make the changes to expose the proper public API and send an update to the original KIP-768 voting thread so that people are aware of the minor public changes if any.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kirktrue commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
kirktrue commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060929594


   Yes.
   
   Users of the OAuth code will not necessarily _code_ against the classes in this package, but they will need to specify the class names from this package in their config. So it's helpful that the documentation be included for reference for config options and a description of the code behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060972154


   If that's the case, then we should only have that one public class in this package. The rest should either be non public or in other packages. Is that how it is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057621295


   The latest build results look good. The most failed tests also failed in `trunk` build. (ref: https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/731/#showFailuresLink). 
   
   ```
       Build / ARM / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
       Build / JDK 17 and Scala 2.13 / integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerNewIBP()
       Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPreferredReplicaElection, Security=PLAINTEXT
       Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
       Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector
       Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
       Build / JDK 8 and Scala 2.12 / kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir()
       Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
       Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
       Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
   ```
   The most frequent flaky tests are under investigation and working on the fix:
   1. `shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
   ` is fixing in this PR: https://github.com/apache/kafka/pull/11827
   2. `testThreadPoolResize` is fixing in this PR: https://github.com/apache/kafka/pull/11821
   3. `LeaderElectionCommandTest` is fixing in this PR: https://github.com/apache/kafka/pull/11681
   
   The remaining are some flaky tests happened not so frequently.
   
   PS. I've noticed the many flaky tests issue, and are working with the community to make it better. At least, the frequent failed tests should be fixed soon!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1058343997


   @justinrlee : It would be useful to submit a similar PR to 3.1 too. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] kirktrue commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
kirktrue commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063190001


   No, all of the classes (public and non-public) are in the package together. Separating them out should be trivial from a code standpoint but please advise on what is needed to change that the proper way from a process standpoint (KIP, Jira, etc.).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057265502


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] justinrlee commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
justinrlee commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057405597


   Just submitted two commits (add space, and then undo).  Will monitor this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057264948


   ok to test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1060727973


   Just to double check, @kirktrue this are intended to be public API?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

Posted by GitBox <gi...@apache.org>.
junrao commented on pull request #11811:
URL: https://github.com/apache/kafka/pull/11811#issuecomment-1057264477


   test this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org