You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/11/07 07:39:34 UTC

[jira] [Commented] (SOLR-6715) ZkSolrResourceLoader constructors accept a parameter called "collection" but it should be "configName"

    [ https://issues.apache.org/jira/browse/SOLR-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14201690#comment-14201690 ] 

ASF subversion and git services commented on SOLR-6715:
-------------------------------------------------------

Commit 1637296 from shalin@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1637296 ]

SOLR-6715: ZkSolrResourceLoader constructors accept a parameter called 'collection' but it should be 'configName'

> ZkSolrResourceLoader constructors accept a parameter called "collection" but it should be "configName"
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6715
>                 URL: https://issues.apache.org/jira/browse/SOLR-6715
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Trivial
>         Attachments: SOLR-6715.patch
>
>
> {code}
> public ZkSolrResourceLoader(String instanceDir, String collection,
>       ZkController zooKeeperController);
> public ZkSolrResourceLoader(String instanceDir, String collection, ClassLoader parent,
>       Properties coreProperties, ZkController zooKeeperController);
> {code}
> The CloudConfigSetService created ZkSolrResourceLoader using the configName (which is correct).
> We should renamed the param in ZkSolrResourceLoader to be configSetName and also rename the "collectionZkPath" member to be "configSetZkPath"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org