You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/13 01:15:05 UTC

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11922


Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

The following docs were touched for the 3.1 release:
- impala_keydefs.ditamap
- impala_fixed_issues.xml
- impala_incompatible_changes.xml
- impala_new_features.xml

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
4 files changed, 28 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11922/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Reviewed-on: http://gerrit.cloudera.org:8080/11922
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_upgrading.xml
5 files changed, 41 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Borok-Nagy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Nov 2018 10:32:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/143/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 01:15:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/145/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 21:36:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/146/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:22:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/145/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 21:38:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@150
PS3, Line 150: impala_privileges_516
> nit: shouldn't it be impala_privileges_30?
A good catch! Fixed.


http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@151
PS3, Line 151: Receive
> The title implies that there exists an upgrade mechanism that will grant RE
Done


http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@154
PS3, Line 154: Sentry and
> remove Sentry.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:20:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/143/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 01:24:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4:

(2 comments)

Zoltan, 
Please make the url of the changelog to be:  https://impala.apache.org/docs/changelog-3.1.html

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml@48
PS4, Line 48:   <concept rev="3.1.0" id="fixed_issues_3_1_0">
> Nit: don't we need the 'All 3.1.x subsections go under here' xml comment he
Done


http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml@48
PS4, Line 48:   <concept rev="3.1.0" id="new_features_31">
> Nit: the concepts under have an xml comment "All ... new features go under 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 19:46:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 5: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/157/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 19:49:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11922

to look at the new patch set (#4).

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_upgrading.xml
5 files changed, 39 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11922/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4:

Zoltan,
Could you review these release related docs for 3.1? Thank you!


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Nov 2018 20:21:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11922

to look at the new patch set (#5).

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_upgrading.xml
5 files changed, 41 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11922/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:21:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/146/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:20:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

Sorry, I somehow missed the review request, only found two nits, but otherwise lgtm.

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml
File docs/topics/impala_fixed_issues.xml:

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_fixed_issues.xml@48
PS4, Line 48:   <concept rev="3.1.0" id="fixed_issues_3_1_0">
Nit: don't we need the 'All 3.1.x subsections go under here' xml comment here just for being consistent?


http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

http://gerrit.cloudera.org:8080/#/c/11922/4/docs/topics/impala_new_features.xml@48
PS4, Line 48:   <concept rev="3.1.0" id="new_features_31">
Nit: the concepts under have an xml comment "All ... new features go under here"



-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 16:19:05 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:

http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@150
PS3, Line 150: impala_privileges_516
nit: shouldn't it be impala_privileges_30?


http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@151
PS3, Line 151: Receive
The title implies that there exists an upgrade mechanism that will grant REFRESH privilege. Maybe we should reword it to "Grant REFRESH Privilege to Impala Roles with SELECT or INSERT Privilege".


http://gerrit.cloudera.org:8080/#/c/11922/3/docs/topics/impala_upgrading.xml@154
PS3, Line 154: Sentry and
remove Sentry.



-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 22:11:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/144/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 21:35:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/157/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Nov 2018 19:44:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 )

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/144/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Nov 2018 21:28:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11922

to look at the new patch set (#3).

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_upgrading.xml
5 files changed, 40 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11922/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11922

to look at the new patch set (#2).

Change subject: IMPALA-7815: [DOCS] Release notes for 3.1
......................................................................

IMPALA-7815: [DOCS] Release notes for 3.1

Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_fixed_issues.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_new_features.xml
M docs/topics/impala_upgrading.xml
5 files changed, 40 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11922/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4d124557f29e539f97c5c52606c16f4147ab169
Gerrit-Change-Number: 11922
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>