[jira] [Commented] (HBASE-9300) Deal with Hadoop Syncable.sync() removal

["Eric Charles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747734#comment-13747734 ] 

Eric Charles commented on HBASE-9300:
-------------------------------------

I always love Stack assertions :)

I've been paid 3 months to migrate a bunch of ant crappy projects to maven. After that miracle, the projects and I were still alive, and well. So to me, maven is a good stuff and deserves its meaning "accumulator of knowledge" ;) http://maven.apache.org/what-is-maven.html

More seriously, HBASE-9123 is about maven, but not about Hadoop3. The sync method has been removed only for the H3 line (not H1, nor H2). Did you have a look to the proposal I made in https://issues.apache.org/jira/secure/attachment/12599199/HBASE-6581-20130821.patch to nicely build on H1,H2/H3?

                
> Deal with Hadoop Syncable.sync() removal
> ----------------------------------------
>
>                 Key: HBASE-9300
>                 URL: https://issues.apache.org/jira/browse/HBASE-9300
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eric Charles
>
> HADOOP-8124 has removed Syncable.sync() in favor of Syncable.hsync().
> Our ProtobufLogWriter calls sync(), which breaks the build when building with Hadoop 3.0.0-SNAPSHOT.
> HBASE-6581 proposes to use reflection in the compat modules to call the correct method (sync for hadoop1* and hadoop2* profiles, hsync for hadoop3 profiles).
> This JIRA is here to validate this approach.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira