You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Knut O. Hellan (JIRA)" <ji...@apache.org> on 2011/09/19 10:12:08 UTC
[jira] [Issue Comment Edited] (THRIFT-1343) no_auto_import min/2 to
avoid compile warning
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107673#comment-13107673 ]
Knut O. Hellan edited comment on THRIFT-1343 at 9/19/11 8:10 AM:
-----------------------------------------------------------------
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does not give errors and the exported test function works as a min function. Adding the directive should not cause problems for R13B04 either.
That being said, using erlang:min/2 would have made more sense unless the point of the internal functions is to be very visible reminders that they should be removed at some point
was (Author: khellan):
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does not give errors and the exported test function works as a min function. Adding the directive should not cause problems for R13B04 either.
That being said, using erlang:min/2 would have made more sense unless the point of this is to works as reminders.
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira