You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "infdahai (via GitHub)" <gi...@apache.org> on 2023/06/27 10:05:01 UTC
[GitHub] [kvrocks] infdahai opened a new issue, #1520: add the skip points for KeyRange
infdahai opened a new issue, #1520:
URL: https://github.com/apache/kvrocks/issues/1520
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Motivation
Do we need to add a position to ignore the numkey integer? For example, we are currently add a wrong key in the `watch` command in [zdiffstore](https://redis.io/commands/zdiffstore/) and [zinterstore](https://redis.io/commands/zinterstore/).
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] torwig commented on issue #1520: add the skip points for KeyRange
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1611687837
@infdahai Could you please elaborate on this? It's not clear to me from the `Motivation` part what issue you want to solve and what solution/solutions you consider/offer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] infdahai commented on issue #1520: add the skip points for KeyRange
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1620400470
Ok, I will add this method. That's a pretty immature *skip points*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] PragmaTwice commented on issue #1520: add the skip points for KeyRange
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1621268885
> BTW, do we use the vector to store `CommandKeyRange`? like this `{{2,1+numkeys,1},{4+numkeys,-1,1}}`
>
> I think it will show well.
Looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] infdahai commented on issue #1520: add the skip points for KeyRange
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1620571358
BTW, does we use the vec to store `CommandKeyRange`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] infdahai commented on issue #1520: add the skip points for KeyRange
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1611762688
I see the function iterates over `range.key_step`. And it will find the argument[i] to exec the watching. https://github.com/apache/kvrocks/blob/8539ee50c7ed74dfd35a396d138efbc8bde65542/src/server/server.cc#L1659-L1670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] PragmaTwice closed issue #1520: add the skip points for KeyRange
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed issue #1520: add the skip points for KeyRange
URL: https://github.com/apache/kvrocks/issues/1520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] infdahai commented on issue #1520: add the skip points for KeyRange
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1609195327
@PragmaTwice do you think it is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] infdahai commented on issue #1520: add the skip points for KeyRange
Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1611767706
The unnecssary numkey will be added into the finding. I think it's innocuous because the numkey shouldn't exist in watched_key_map_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] PragmaTwice commented on issue #1520: add the skip points for KeyRange
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1520:
URL: https://github.com/apache/kvrocks/issues/1520#issuecomment-1618817592
The current key range design is divided to two methods:
- a *static* constant [start, end, step] if the key range can be determined without actual commands, e.g. `GET key`
- a *dynamic* [start, end, step] according to actual commands, e.g. `opname numkeys key... someflag`
To generalize the key range design to a more pervasive form, I think we can add the third method:
- a *static* constant [start, end, step] if the key range can be determined without actual commands, e.g. `GET key` -> [1,1,1]
- a *dynamic* [start, end, step] according to actual commands, e.g. `opname numkeys key... someflag` -> [2, 1+numkeys,1]
- a *dynamic* key position vector according to actual commands, e.g. `opname numkeys1 key1... someflag numkeys2 key2... someflag` -> {2,3,...,1+numkeys1,4+numkeys1,...,3+numkeys1+numkeys2}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org