You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/02/18 15:09:53 UTC
[GitHub] [tomcat] mads1980 commented on issue #246: OpenSSLEngine
improvements to guard against multiple shutdown() calls triggered by
construction exception and finalize() later
mads1980 commented on issue #246: OpenSSLEngine improvements to guard against multiple shutdown() calls triggered by construction exception and finalize() later
URL: https://github.com/apache/tomcat/pull/246#issuecomment-587507009
Hi Remy, thank you for your feedback. Object.finalize() has been
deprecated since Java 9 because of its weird subtleties. Still, even if
the JVM behaviour is broken, shouldn't we still fix this? The solution
seems simple enough, especially if this would avoid JVM crashes.
*
Manuel Dominguez Sarmiento*
On 18/02/2020 11:31, Rémy Maucherat wrote:
>
> It's quite normal as the problem was evident and legitimate with
> OpenSSLContext, while with OpenSSLEngine I consider the JVM is broken.
> I'd like to remind that the engine is referenced directly from the
> channel, and then the JVM seems to happily discard everything in a
> random order. So: whatever ...
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomcat/pull/246?email_source=notifications&email_token=ABDXTFDYUKPSC62S7QRWL43RDPWNBA5CNFSM4KXFMPI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMCFW4A#issuecomment-587488112>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABDXTFB3FH4YLXDFOW2KRN3RDPWNBANCNFSM4KXFMPIQ>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org