You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/12 12:57:08 UTC

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1159: [CALCITE-2993] ParseException may be thrown for legal SQL queries due…

zhztheplayer commented on a change in pull request #1159: [CALCITE-2993] ParseException may be thrown for legal SQL queries due…
URL: https://github.com/apache/calcite/pull/1159#discussion_r274893754
 
 

 ##########
 File path: core/src/main/codegen/templates/Parser.jj
 ##########
 @@ -1894,7 +1894,7 @@ SqlNode TableRef2(boolean lateral) :
             tableRef = unnestOp.createCall(s.end(this), args.toArray());
         }
     |
-        [ LOOKAHEAD(1) <LATERAL> { lateral = true; } ]
 
 Review comment:
   This one is removed cause it is redundant:
   1. For core parsers (global lookahead = 1), the `LOOKAHEAD(1)` is already implied;
   2. For babel parser (global lookahead = 2), `[LOOKAHEAD(1) <FOO>]` is not faster than `[LOOKAHEAD(2) <FOO>]`. They are basically equivalent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services