You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/12 10:39:37 UTC
[GitHub] [solr] betulince opened a new pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
betulince opened a new pull request #436:
URL: https://github.com/apache/solr/pull/436
https://issues.apache.org/jira/browse/SOLR-15824
# Description
While sending a query in solr, it is very convenient that the q field can be resizable(because it's in textarea tag), while the fq and raw query parameters fields are not resizable, which can cause difficulties in long query parameters. To solve this made improvement on query.html and query.css.
# Solution
I put fq and raw query parameters inside textarea tag and with css I made it vertical resizable because of the line between query and result. Because if it was resizable both vertical and horizontal or only horizontal, it would cause the appearance of the panel to deteriorate.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
# EDIT
I changed only raw query parameters section because of the comments on PR. Added +/- buttons for raw query parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991873888
I closed PR by accident, fyi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984742300
Does having each fq make sense to be a text area? Do they actually get really long when they get split up like this:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince edited a comment on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince edited a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991874554
> Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query) ... I think you need to have rawParams for this 2x behavior to happen.
The query form isn't getting submitted 2x everytime I click the Execute Query button anymore.
When it says execute query, it does not run the query and print the result. Add parameters to the url, refresh the page, run a query on the solr side at that stage, and print the result, as doQuery will already run after you refresh the page.
`if (isPageReload) {`
That's why I put the control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-987101361
> This is a nice improvement, how would you like to be credited in CHANGES.txt?
Of course!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991873382
> I suspect this is probably an existing bug (not introduced by the changes in this PR) (see screenshot), but if you supply the same parameter more than once, such as `stats.field` (to get stats for multiple fields), then the values get concatenated into a single comma-delimited list sent to the server like `"stats.field":"pages_i,price"`. <img alt="Screen Shot 2021-12-10 at 2 08 47 PM" width="684" src="https://user-images.githubusercontent.com/417074/145645598-468774f8-6afd-460b-9854-daec7d2bf517.png">
>
> I'd like to see this bug fixed as part of this PR if you're up to it @betulince ? If not, we can tackle under another change / JIRA. I suspect is b/c the form is getting submitted 2x everytime I click the `Execute Query` button?!? The first time the query succeeds but then it re-submits with `"stats.field":"pages_i,price"` which fails. <img alt="Screen Shot 2021-12-10 at 2 47 52 PM" width="537" src="https://user-images.githubusercontent.com/417074/145645596-31a2cd5a-9d1a-47f4-a9cf-fcb7d60d57ab.png">
>
> Also, line 51 is calling `addRawParams(urlParams[p]);` which doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
epugh merged pull request #436:
URL: https://github.com/apache/solr/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-985879938
My suggestion was to provide the option of + / - or the resizable text area vs. one or the other ... at some point even the resizable text area will be hard to see all the details if there are enough parameters. Be cool if I could paste in a long query string of params, have the JS parse them when I switch over to the +/- ... I know this form pretty well from adapting it for the query tester in Schema Designer. I can take a stab at an implementation there to show the concept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-987099314
> > What do you mean ? It's already 2 rows Eric Pugh _**@**_.***>, 2 Ara 2021 Per, 18:40 tarihinde şunu yazdı:
> > For some reason it looked like three in my browser!!!
>
> However, I think that @thelabdude suggestion of instead using the +/- is a better route than the text area!
Added +/- buttons for raw query parameters. Tests are done. There is no problem about sending and executing queries and taking results as you can see from screenshot:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on a change in pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude commented on a change in pull request #436:
URL: https://github.com/apache/solr/pull/436#discussion_r770007059
##########
File path: solr/webapp/web/js/angular/controllers/query.js
##########
@@ -176,18 +183,21 @@ solrAdminApp.controller('QueryController',
if( $scope.qt != null ) {
adminParams.qt = [$scope.qt];
}
-
- Query.query(params, function(data) {
- $scope.lang = $scope.val['wt'];
- if ($scope.lang == undefined || $scope.lang == '') {
- $scope.lang = "json";
- }
- $scope.response = data;
- // Use relative URL to make it also work through proxies that may have a different host/port/context
- $scope.url = url;
- $scope.hostPortContext = $location.absUrl().substr(0,$location.absUrl().indexOf("#")); // For display only
+ if (isPageReload) {
Review comment:
awesome! good fix here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince removed a comment on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince removed a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991873382
> I suspect this is probably an existing bug (not introduced by the changes in this PR) (see screenshot), but if you supply the same parameter more than once, such as `stats.field` (to get stats for multiple fields), then the values get concatenated into a single comma-delimited list sent to the server like `"stats.field":"pages_i,price"`. <img alt="Screen Shot 2021-12-10 at 2 08 47 PM" width="684" src="https://user-images.githubusercontent.com/417074/145645598-468774f8-6afd-460b-9854-daec7d2bf517.png">
>
> I'd like to see this bug fixed as part of this PR if you're up to it @betulince ? If not, we can tackle under another change / JIRA. I suspect is b/c the form is getting submitted 2x everytime I click the `Execute Query` button?!? The first time the query succeeds but then it re-submits with `"stats.field":"pages_i,price"` which fails. <img alt="Screen Shot 2021-12-10 at 2 47 52 PM" width="537" src="https://user-images.githubusercontent.com/417074/145645596-31a2cd5a-9d1a-47f4-a9cf-fcb7d60d57ab.png">
>
> Also, line 51 is calling `addRawParams(urlParams[p]);` which doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991321741
I suspect this is probably an existing bug (not introduced by the changes in this PR) (see screenshot), but if you supply the same parameter more than once, such as `stats.field` (to get stats for multiple fields), then the values get concatenated into a single comma-delimited list sent to the server like `"stats.field":"pages_i,price"`.
<img width="684" alt="Screen Shot 2021-12-10 at 2 08 47 PM" src="https://user-images.githubusercontent.com/417074/145645598-468774f8-6afd-460b-9854-daec7d2bf517.png">
I'd like to see this bug fixed as part of this PR if you're up to it @betulince ? If not, we can tackle under another change / JIRA. I suspect is b/c the form is getting submitted 2x everytime I click the `Execute Query` button?!? The first time the query succeeds but then it re-submits with `"stats.field":"pages_i,price"` which fails.
<img width="537" alt="Screen Shot 2021-12-10 at 2 47 52 PM" src="https://user-images.githubusercontent.com/417074/145645596-31a2cd5a-9d1a-47f4-a9cf-fcb7d60d57ab.png">
Also, line 51 is calling `addRawParams(urlParams[p]);` which doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-995143158
'Betul Ince' is good.
Thank you!!
On Wed, Dec 15, 2021, 10:30 PM Eric Pugh ***@***.***> wrote:
> How do you want your name listed in the change log? Betul Ince or maybe
> betulince?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-995130568>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2GKECO4H5N23IUI6MDURDUERANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-994868088
@betulince I put two small comments in, and this code looks great! Learned some stuff about Angular ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-995130568
How do you want your name listed in the change log? `Betul Ince` or maybe `betulince`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-994787853
bug solved, fyi.
can you check if it's giving another errors ?
Timothy Potter ***@***.***>, 11 Ara 2021 Cmt, 00:55 tarihinde
şunu yazdı:
> Confirmed ... the query form getting submitted 2x each time you push the Execute
> Query button exists on main! So that's bad and looks to be the cause of
> why having stats.field=f1&stats.field=f2 fails (b/c of how the params are
> processed for the 2nd query)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-991330781>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2C6NAMJSMTUIRCRRK3UQJZNLANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-995167070
> @betulince I went ahead and made the changes that I suggested, and want to push to your branch, can you give me permissions? I think it's a checkbox to "allow committers to push to branch" or something like that! I'll get the changelog updated and this merged!!!
You already committed I guess!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991321741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991139800
I'll kick the tires on this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-985849618
What do you mean ? It's already 2 rows
Eric Pugh ***@***.***>, 2 Ara 2021 Per, 18:40 tarihinde şunu
yazdı:
> Maybe we have a text area that starts out as two rows intesead of three?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-984744152>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2BKZUONQHHCHFIX4YDUO6HNDANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984969452
Hello,
It's a really good idea to have +/- for raw parameters like in fq, I will
work on it!!
And I would like to be on CHANGES.txt, it would make me more motivated to
work on UI/UX for admin page or query screen!
And about having fq textarea, I will talk about it with my company because
we are using Solr everyday in our company. I will see if it's worth to do
it or not.
On Thu, Dec 2, 2021, 10:41 PM Eric Pugh ***@***.***> wrote:
> That makes sense to me @thelabdude <https://github.com/thelabdude>...
> what do you think @betulince <https://github.com/betulince> ???
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-984944293>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2A6GKS2TIXOC2I7SMTUO7DXRANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984746301
This is a nice improvement, how would you like to be credited in CHANGES.txt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince closed pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince closed pull request #436:
URL: https://github.com/apache/solr/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh edited a comment on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh edited a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984742300
Does having each fq make sense to be a text area? Do they actually get really long when they get split up like this:
Where as with out this patch, it looks like:
Do we have really long wrapping fq's ??????
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-985870653
> What do you mean ? It's already 2 rows Eric Pugh ***@***.***>, 2 Ara 2021 Per, 18:40 tarihinde şunu yazdı:
For some reason it looked like three in my browser!!!
However, I think that @thelabdude suggestion of instead using the +/- is a better route than the text area!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984942235
I think it would be nice to have a + / - list for raw params like we have for `fq` ... perhaps with a toggle between a list of text boxes or the textarea added to this PR? The textarea is an improvement for sure, but with a long list, it might still be better to separate each parameter out in its own line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude edited a comment on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude edited a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991330781
Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query) ... I think you need to have rawParams for this 2x behavior to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991616637
I'll fix what you mentioned above with this PR.
On Sat, Dec 11, 2021, 12:55 AM Timothy Potter ***@***.***>
wrote:
> Confirmed ... the query form getting submitted 2x each time you push the Execute
> Query button exists on main! So that's bad and looks to be the cause of
> why having stats.field=f1&stats.field=f2 fails (b/c of how the params are
> processed for the 2nd query)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-991330781>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2C6NAMJSMTUIRCRRK3UQJZNLANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude edited a comment on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude edited a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991330781
Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query) ... I think you need to have rawParams for this 2x behavior to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
thelabdude commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991330781
Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984944293
That makes sense to me @thelabdude... what do you think @betulince ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-987094156
> Just gave it a try and it looks great! A bit of extra space makes a nice bit of difference.
>
> 
>
> Also, I didn't know that if I put `fq=manu_id_s:corsair`, in the raw params, they get yanked up to the fq section~ cool.
I took back the changes on fq section based on your comments. There is no need to add resizable area when we already have +/- buttons for parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984744152
Maybe we have a text area that starts out as two rows intesead of three?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: Improved Query Screen fq and raw query parameters sections
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-984739593
Just gave it a try and it looks great! A bit of extra space makes a nice bit of difference.
Also, I didn't know that if I put `fq=manu_id_s:corsair`, in the raw params, they get yanked up to the fq section~ cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-995158508
@betulince I went ahead and made the changes that I suggested, and want to push to your branch, can you give me permissions? I think it's a checkbox to "allow committers to push to branch" or something like that! I'll get the changelog updated and this merged!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991616637
I'll fix what you mentioned above with this PR.
On Sat, Dec 11, 2021, 12:55 AM Timothy Potter ***@***.***>
wrote:
> Confirmed ... the query form getting submitted 2x each time you push the Execute
> Query button exists on main! So that's bad and looks to be the cause of
> why having stats.field=f1&stats.field=f2 fails (b/c of how the params are
> processed for the 2nd query)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/solr/pull/436#issuecomment-991330781>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AKSKE2C6NAMJSMTUIRCRRK3UQJZNLANCNFSM5JHDWGRQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991874985
> I suspect this is probably an existing bug (not introduced by the changes in this PR) (see screenshot), but if you supply the same parameter more than once, such as `stats.field` (to get stats for multiple fields), then the values get concatenated into a single comma-delimited list sent to the server like `"stats.field":"pages_i,price"`. <img alt="Screen Shot 2021-12-10 at 2 08 47 PM" width="684" src="https://user-images.githubusercontent.com/417074/145645598-468774f8-6afd-460b-9854-daec7d2bf517.png">
>
> I'd like to see this bug fixed as part of this PR if you're up to it @betulince ? If not, we can tackle under another change / JIRA. I suspect is b/c the form is getting submitted 2x everytime I click the `Execute Query` button?!? The first time the query succeeds but then it re-submits with `"stats.field":"pages_i,price"` which fails. <img alt="Screen Shot 2021-12-10 at 2 47 52 PM" width="537" src="https://user-images.githubusercontent.com/417074/145645596-31a2cd5a-9d1a-47f4-a9cf-fcb7d60d57ab.png">
>
> Also, line 51 is calling `addRawParams(urlParams[p]);` which doesn't exist?
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince commented on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince commented on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991874554
> Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query) ... I think you need to have rawParams for this 2x behavior to happen.
The query form isn't getting submitted 2x everytime I click the Execute Query button anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] betulince edited a comment on pull request #436: SOLR-15824 Improved Query Screen raw query parameters section
Posted by GitBox <gi...@apache.org>.
betulince edited a comment on pull request #436:
URL: https://github.com/apache/solr/pull/436#issuecomment-991874554
> Confirmed ... the query form getting submitted 2x each time you push the `Execute Query` button exists on main! So that's bad and looks to be the cause of why having `stats.field=f1&stats.field=f2` fails (b/c of how the params are processed for the 2nd query) ... I think you need to have rawParams for this 2x behavior to happen.
The query form isn't getting submitted 2x everytime I click the Execute Query button anymore.
When it says execute query, it does not run the query and print the result. Add parameters to the url, refresh the page, run a query on the solr side at that stage, and print the result, as doQuery will already run after you refresh the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org