[jira] [Resolved] (GEODE-9128) Remove host name look-up from JGAddress

["Bruce J Schuchardt (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-9128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce J Schuchardt resolved GEODE-9128.
---------------------------------------
    Fix Version/s: 1.15.0
       Resolution: Fixed

PR for backport to 1.14 is up so I'm closing this ticket.

> Remove host name look-up from JGAddress
> ---------------------------------------
>
>                 Key: GEODE-9128
>                 URL: https://issues.apache.org/jira/browse/GEODE-9128
>             Project: Geode
>          Issue Type: Test
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Bruce J Schuchardt
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> The method JGAddress.toString() contains a host name lookup that should be removed.  It should just log the toString of its ip_addr field, not ip_addr.getHostName().  That method can cause a reverse-DNS lookup, which is needlessly expensive for a toString() operation.
> {code:java}
>   public String toString() {
>     StringBuilder sb = new StringBuilder();
>     if (ip_addr == null)
>       sb.append("<null>");
>     else {
>       sb.append(ip_addr.getHostName());
>     }
>     if (vmViewId >= 0) {
>       sb.append("<v").append(vmViewId).append('>');
>     }
>     if (SHOW_UUIDS) {
>       sb.append("(").append(toStringLong()).append(")");
>     } else if (mostSigBits == 0 && leastSigBits == 0) {
>       sb.append("(no uuid set)");
>     }
>     sb.append(":").append(port);
>     return sb.toString();
>   }
> {code:java}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)