You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/09 02:14:30 UTC

[jira] [Commented] (HBASE-4176) Exposing HBase Filters to the Thrift API

    [ https://issues.apache.org/jira/browse/HBASE-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081321#comment-13081321 ] 

jiraposter@reviews.apache.org commented on HBASE-4176:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1326/
-----------------------------------------------------------

Review request for hbase, Todd Lipcon, Ted Yu, Michael Stack, and Jonathan Gray.


Summary
-------

https://issues.apache.org/jira/browse/HBASE-4176: Exposing HBase Filters to the Thrift API

Currently, to use any of the filters, one has to explicitly add a scanner for the filter in the Thrift API making it messy and long. 
With this patch, I am trying to add support for all the filters in a clean way. 
The user specifies a filter via a string. The string is parsed on the server to construct the filter. More information can be found in the attached document named Filter Language

This patch is trying to extend and further the progress made by the patches in HBASE-1744

There is document attached to the HBASE-4176 JIRA that describes this patch in further detail


This addresses bug HBASE-4176.
    https://issues.apache.org/jira/browse/HBASE-4176


Diffs
-----

  /src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/Filter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/FilterList.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueExcludeFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java 1155098 
  /src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java 1155098 
  /src/test/java/org/apache/hadoop/hbase/filter/TestParseFilter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1326/diff


Testing
-------

patch includes one test: TestParseFilter.java


Thanks,

Anirudh



> Exposing HBase Filters to the Thrift API
> ----------------------------------------
>
>                 Key: HBASE-4176
>                 URL: https://issues.apache.org/jira/browse/HBASE-4176
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: Anirudh Todi
>            Assignee: Anirudh Todi
>            Priority: Minor
>         Attachments: Filter Language.docx, HBASE-4176.patch
>
>
> Currently, to use any of the filters, one has to explicitly add a scanner for the filter in the Thrift API making it messy and long. With this patch, I am trying to add support for all the filters in a clean way. The user specifies a filter via a string. The string is parsed on the server to construct the filter. More information can be found in the attached document named Filter Language
> This patch is trying to extend and further the progress made by the patches in the HBASE-1744 JIRA (https://issues.apache.org/jira/browse/HBASE-1744)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira