You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 23:01:25 UTC
[GitHub] [airflow] andrewgodwin opened a new pull request #17564: Fixed long delays never returning in the Temporal trigger
andrewgodwin opened a new pull request #17564:
URL: https://github.com/apache/airflow/pull/17564
This trigger was never actually working for delays over two hours, as it was comparing a Pendulum.Period to a datetime.datetime, in a way that always returned `True`.
This commit fixes the behaviour. This unfortunately seems un-testable, as it's not possible to interrupt asyncio's sleep() while it's in-flight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17564: Fixed long delays never returning in DateTimeTrigger
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17564:
URL: https://github.com/apache/airflow/pull/17564#issuecomment-897967887
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17564: Fixed long delays never returning in DateTimeTrigger
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17564:
URL: https://github.com/apache/airflow/pull/17564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org