You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/02/07 00:27:28 UTC
[jira] Created: (CASSANDRA-775) Allow token range queries over
Thrift
Allow token range queries over Thrift
-------------------------------------
Key: CASSANDRA-775
URL: https://issues.apache.org/jira/browse/CASSANDRA-775
Project: Cassandra
Issue Type: New Feature
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 0.6
This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-775) Allow token range
queries over Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830813#action_12830813 ]
Stu Hood edited comment on CASSANDRA-775 at 2/8/10 2:42 AM:
------------------------------------------------------------
> I don't understand the question... using start_key and end_key works like "classic" RQ.
Right, but since you don't get Token strings back when you query, you can't requery using a new Token.
EDIT: Hmm, I guess for the second query you can use a start_key and a finish_token. Is that the idea?
EDIT2: Actually, that would be invalid with this patch, so the question stands.
was (Author: stuhood):
> I don't understand the question... using start_key and end_key works like "classic" RQ.
Right, but since you don't get Token strings back when you query, you can't requery using a new Token.
EDIT: Hmm, I guess for the second query you can use a start_key and a finish_token. Is that the idea?
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830813#action_12830813 ]
Stu Hood commented on CASSANDRA-775:
------------------------------------
> I don't understand the question... using start_key and end_key works like "classic" RQ.
Right, but since you don't get Token strings back when you query, you can't requery using a new Token.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830818#action_12830818 ]
Stu Hood commented on CASSANDRA-775:
------------------------------------
Hmm, I'd like to find a way that puts clients on more equal footing if possible. Requiring the key->token conversion on the client side for paging is ugly.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-775:
-------------------------------------
Attachment: 775.txt
rebased.
i also note that if adding a token to keyslice does end up being the best way to solve really large numbers of keys, it can be done by adding an optional field to the struct w/o breaking backwards compatibility.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830812#action_12830812 ]
Jonathan Ellis commented on CASSANDRA-775:
------------------------------------------
I don't understand the question... using start_key and end_key works like "classic" RQ.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-775:
-------------------------------------
Attachment: 775-with-thrift.txt
we always include the thrift revision in the lib/ file so it's easy to svn up to the right one. but here is a patch w/ the thrift changes bundled.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775-with-thrift.txt, 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-775:
-------------------------------------
Attachment: 775.txt
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-775) Allow token range
queries over Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830813#action_12830813 ]
Stu Hood edited comment on CASSANDRA-775 at 2/8/10 2:40 AM:
------------------------------------------------------------
> I don't understand the question... using start_key and end_key works like "classic" RQ.
Right, but since you don't get Token strings back when you query, you can't requery using a new Token.
EDIT: Hmm, I guess for the second query you can use a start_key and a finish_token. Is that the idea?
was (Author: stuhood):
> I don't understand the question... using start_key and end_key works like "classic" RQ.
Right, but since you don't get Token strings back when you query, you can't requery using a new Token.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830820#action_12830820 ]
Stu Hood commented on CASSANDRA-775:
------------------------------------
What about adding a Token to KeySlice?
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832763#action_12832763 ]
Stu Hood commented on CASSANDRA-775:
------------------------------------
Would you mind adding a compiled version of KeyRange to the patch? Trying to find a thrift version to rebuild the server interface with is painful.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833175#action_12833175 ]
Jonathan Ellis commented on CASSANDRA-775:
------------------------------------------
>From IRC:
stuhood: my +1 is to get both merged, and then open a new ticket to fix getSplits and add paging
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775-with-thrift.txt, 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-775:
-------------------------------------
Attachment: (was: 775.txt)
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830823#action_12830823 ]
Jonathan Ellis commented on CASSANDRA-775:
------------------------------------------
if you're not doing parallel queries you have no need to use the token api over keys anyway. so i'd be against adding cruft to the api in the absence of an actual use case for it.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-775) Allow token range
queries over Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832763#action_12832763 ]
Stu Hood edited comment on CASSANDRA-775 at 2/12/10 12:49 AM:
--------------------------------------------------------------
Would you mind adding a compiled version of KeyRange to the patch? Trying to find a thrift version to rebuild the server interface with is painful.
EDIT: And the changes to Cassandra.Client.
was (Author: stuhood):
Would you mind adding a compiled version of KeyRange to the patch? Trying to find a thrift version to rebuild the server interface with is painful.
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830815#action_12830815 ]
Jonathan Ellis commented on CASSANDRA-775:
------------------------------------------
it's really only intended for hadoop, which parallelizes the queries anyway
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834868#action_12834868 ]
Hudson commented on CASSANDRA-775:
----------------------------------
Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775-with-thrift.txt, 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830808#action_12830808 ]
Stu Hood commented on CASSANDRA-775:
------------------------------------
It really is too bad Thrift doesn't support method overloading... sigh.
After calling get_range_slices with a KeyRange limited to N rows, how do you make another call to get rows starting from N?
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-775) Allow token range queries over
Thrift
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830817#action_12830817 ]
Jonathan Ellis commented on CASSANDRA-775:
------------------------------------------
(but, anyone who knows how partitioner works, which is trivial w/ java clients and not hard for others, would be welcome to compute tokens from keys)
> Allow token range queries over Thrift
> -------------------------------------
>
> Key: CASSANDRA-775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-775
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 0.6
>
> Attachments: 775.txt
>
>
> This will allow using Thrift from hadoop jobs, which makes me a little sad but MessagingService is just not a good fit for how Hadoop wants to run jobs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.