You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/12/05 10:03:53 UTC
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19319
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
We saw several test failures on collecting file metadata after minor
compaction in Hive. However, I can't reproduce the failure by running
the tests around 100 times.
To ease our debug, this patch adds error messages to print the actual
file paths. Also adds more logs to locate the time range when the test
runs.
Tests:
- Ran CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
locally. Verified the new logs exist.
- Modified the expected value to fail the tests. Verified the error
messages work as expected.
Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
---
M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java
M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
M fe/src/test/java/org/apache/impala/testutil/HiveJdbcClientPool.java
3 files changed, 41 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/19319/1
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Dec 2022 05:30:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Dec 2022 00:43:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
We saw several test failures on collecting file metadata after minor
compaction in Hive. However, I can't reproduce the failure by running
the tests around 100 times.
To ease our debug, this patch adds error messages to print the actual
file paths. Also adds more logs to locate the time range when the test
runs.
Tests:
- Ran CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
locally. Verified the new logs exist.
- Modified the expected value to fail the tests. Verified the error
messages work as expected.
Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Reviewed-on: http://gerrit.cloudera.org:8080/19319
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoWriteIdTest.java
M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
M fe/src/test/java/org/apache/impala/testutil/HiveJdbcClientPool.java
3 files changed, 41 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8875/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Dec 2022 05:30:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11963/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 10:24:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Dec 2022 10:38:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19319 )
Change subject: IMPALA-11756: Add error messages and debug logs in CatalogdMetaProviderTest and PartialCatalogInfoWriteIdTest
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I806cc35da5a758215b8dc6cc2df86a7a968301da
Gerrit-Change-Number: 19319
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 10:50:04 +0000
Gerrit-HasComments: No