You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "hlteoh37 (via GitHub)" <gi...@apache.org> on 2023/02/22 21:53:24 UTC

[GitHub] [flink] hlteoh37 commented on a diff in pull request #22000: [FLINK-31183][Connector/Kinesis] Fix bug where EFO Consumer can fail …

hlteoh37 commented on code in PR #22000:
URL: https://github.com/apache/flink/pull/22000#discussion_r1115002217


##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutShardSubscriber.java:
##########
@@ -452,7 +477,7 @@ public void onComplete() {
         }
 
         private void cancelSubscription() {
-            if (cancelled) {
+            if (isCancelled()) {

Review Comment:
   could we potentially leak some subscriptions here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org