You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/04/23 16:12:09 UTC

[GitHub] [arrow-rs] izveigor commented on a diff in pull request #4113: feat: support all primitive tensors and buffer builders

izveigor commented on code in PR #4113:
URL: https://github.com/apache/arrow-rs/pull/4113#discussion_r1174606767


##########
arrow/src/tensor.rs:
##########
@@ -85,17 +85,36 @@ pub struct Tensor<'a, T: ArrowPrimitiveType> {
 }
 
 pub type BooleanTensor<'a> = Tensor<'a, BooleanType>;
+pub type Date32Tensor<'a> = Tensor<'a, Date32Type>;

Review Comment:
   Golang Arrow uses Date32 tensor: https://github.com/apache/arrow/blob/main/go/arrow/tensor/numeric.gen.go#L271-L287.
   I think it might be useful to store related dates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org