You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/07/30 22:43:25 UTC
[GitHub] [cassandra] dcapwell commented on a change in pull request #698: CASSANDRA-15980 - Improved log messaging for socket connection/disconnection
dcapwell commented on a change in pull request #698:
URL: https://github.com/apache/cassandra/pull/698#discussion_r463311607
##########
File path: src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
##########
@@ -445,11 +454,11 @@ void setupMessagingPipeline(InetAddressAndPort from, int useMessagingVersion, in
InboundMessageHandler handler =
settings.handlers.apply(from).createHandler(frameDecoder, initiate.type, pipeline.channel(), useMessagingVersion);
- logger.info("{} connection established, version = {}, framing = {}, encryption = {}",
+ logger.info("{} messaging connection established, version = {}, framing = {}, encryption = {}",
Review comment:
before
```
127.0.0.2:7000(127.0.0.1:65115)->127.0.0.1:7000-LARGE_MESSAGES-f53d678a connection established, version = 12, framing = CRC, encryption = enabled (openssl)
```
after
```
127.0.0.2:7000(127.0.0.1:65115)->127.0.0.1:7000-LARGE_MESSAGES-f53d678a messaging connection established, version = 12, framing = CRC, encryption = enabled (openssl)
```
##########
File path: src/java/org/apache/cassandra/net/InboundConnectionInitiator.java
##########
@@ -445,11 +454,11 @@ void setupMessagingPipeline(InetAddressAndPort from, int useMessagingVersion, in
InboundMessageHandler handler =
settings.handlers.apply(from).createHandler(frameDecoder, initiate.type, pipeline.channel(), useMessagingVersion);
- logger.info("{} connection established, version = {}, framing = {}, encryption = {}",
+ logger.info("{} messaging connection established, version = {}, framing = {}, encryption = {}",
Review comment:
personal preference, I prefer the old
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org