You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ashb (via GitHub)" <gi...@apache.org> on 2023/02/16 10:10:06 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #29569: Avoid importing executor during conf validation

ashb commented on code in PR #29569:
URL: https://github.com/apache/airflow/pull/29569#discussion_r1108262943


##########
airflow/configuration.py:
##########
@@ -429,30 +428,34 @@ def _validate_enums(self):
                     )
 
     def _validate_config_dependencies(self):
-        """
-        Validate that config based on condition.
+        """Validate that config based on condition.
 
         Values are considered invalid when they conflict with other config values
         or system-level limitations and requirements.
         """
-        executor, _ = ExecutorLoader.import_default_executor_cls()
-        is_sqlite = "sqlite" in self.get("database", "sql_alchemy_conn")
+        self._validate_sqlite3_version()

Review Comment:
   Rather than calling this from in here, call this function directly from The existing `validate()` function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org