You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/04 18:19:12 UTC

[GitHub] [superset] michael-s-molina commented on a diff in pull request #19438: chore: Remove crud.less from Datasource

michael-s-molina commented on code in PR #19438:
URL: https://github.com/apache/superset/pull/19438#discussion_r842020345


##########
superset-frontend/src/components/Datasource/CollectionTable.tsx:
##########
@@ -102,9 +101,28 @@ const CrudTableWrapper = styled.div<{ stickyHeader?: boolean }>`
         min
       }
     `}
-  th span {
-    vertical-align: ${({ theme }) => theme.gridUnit * -2}px;
-  }
+  ${({ theme }) => `
+    th span {
+      vertical-align: ${theme.gridUnit * -2}px;
+    }
+    .text-right {
+      text-align: right;
+    }
+    .empty-collection {
+      padding: ${theme.gridUnit * 2 + 2}px;

Review Comment:
   I noticed that you removed the `.control-label` and `.frame` classes. It was intended?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org