[jira] [Commented] (IGNITE-29104) Remove dead code from lock candidates and transaction size tracking

["Ignite TC Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-29104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123656#comment-18123656 ] 

Ignite TC Bot commented on IGNITE-29104:
----------------------------------------

{panel:title=Branch: [pull/13651/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13651/head] Base: [master] : No new tests found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9388733&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9388733 rerunBuildIds=9390205,9390207{color}

> Remove dead code from lock candidates and transaction size tracking
> -------------------------------------------------------------------
>
>                 Key: IGNITE-29104
>                 URL: https://issues.apache.org/jira/browse/IGNITE-29104
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Nikita Amelchev
>            Assignee: Nikita Amelchev
>            Priority: Major
>             Fix For: 2.19
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {\{GridCacheMvccCandidate}} assigns every lock candidate an ID from a shared static counter, but the ID is only read by \{{compareTo()}} and the \{{Externalizable}} methods, which are never called: candidates are neither sorted nor serialized.
> {\{IgniteTxAdapter.applyTxSizes()}} is invoked on every transaction commit, but it iterates over \{{TxCounters.sizeDeltas}}, which is never populated.
> Both should be removed to get rid of the dead code and of the needless per-candidate and per-transaction overhead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)