You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 15:02:21 UTC

[GitHub] [flink] lincoln-lil opened a new pull request, #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

lincoln-lil opened a new pull request, #21222:
URL: https://github.com/apache/flink/pull/21222

   ## What is the purpose of the change
   this is the backport pr for FLINK-29849 & FLINK-29781
   
   ## Brief change log 
   for FLINK-29849
   * add a new StreamFilterIntoJoinRule for streaming, it doesn't push a filter into join which is a temporal join using event time.
   * add a FlinkSnapshotRequirementProgram to update snapshot requirement for its child source to avoid adding the ChangelogNormalize node in such cases
   
   for FLINK-29781
   * add the unique key indexes remapping logic for WatermarkAssignerChangelogNormalizeTransposeRule
   
   ## Verifying this change
   TemporalJoinTest & TemporalRowTimeJoinOperatorTest
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil closed pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

Posted by GitBox <gi...@apache.org>.
lincoln-lil closed pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan
URL: https://github.com/apache/flink/pull/21222


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21222:
URL: https://github.com/apache/flink/pull/21222#issuecomment-1300645730

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "26b9b75d144315b19f62fda2ceff8fd076e91a45",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "26b9b75d144315b19f62fda2ceff8fd076e91a45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 26b9b75d144315b19f62fda2ceff8fd076e91a45 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] lincoln-lil commented on pull request #21222: [BP-1.15][FLINK-29849 & FLINK-29781][table-planner] Fix event time temporal join on an upsert source may produce incorrect execution plan

Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #21222:
URL: https://github.com/apache/flink/pull/21222#issuecomment-1361378770

   close the temporary backporting patch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org