You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/16 11:21:12 UTC
[GitHub] flink pull request #6340: [FLINK-9842][rest] Pass actual configuration to Bl...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6340
[FLINK-9842][rest] Pass actual configuration to BlobClient
## What is the purpose of the change
With this PR the `JobSubmitHandler` uses the configured ssl settings when connecting with the `BlobClient`.
## Brief change log
* pass configuration from `DispatcherEndpoint` to `JobSubmitHandler`
* pass configuration from `JobSubmitHandler` to `BlobClient`
## Verifying this change
The `JobSubmitHandlerTest` was modified to run with both ssl enabled and disabled.
Currently, the `testFileHandling` test would fail.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6340
----
commit d2d1f2bc531cfc41819cd1a5a2248b1334a5cd47
Author: zentol <ch...@...>
Date: 2018-07-16T09:32:09Z
[FLINK-9842][rest] Pass actual configuration to BlobClient
commit f8163f570a815ac4e45392e51042ef75bc8c72dd
Author: zentol <ch...@...>
Date: 2018-07-16T10:08:17Z
add test
----
---
[GitHub] flink pull request #6340: [FLINK-9842][rest] Pass actual configuration to Bl...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/6340#discussion_r202653111
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java ---
@@ -57,24 +60,39 @@
/**
* Tests for the {@link JobSubmitHandler}.
*/
+@RunWith(Parameterized.class)
public class JobSubmitHandlerTest extends TestLogger {
+ @Parameterized.Parameters(name = "SSL enabled: {0}")
+ public static Iterable<Boolean> data() {
+ return Arrays.asList(true, false);
+ }
+
@ClassRule
public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
- private static BlobServer blobServer;
- @BeforeClass
- public static void setup() throws IOException {
- Configuration config = new Configuration();
+ private final Configuration sslConfig;
--- End diff --
Strictly speaking, this is not the SSL config (only), but just the configuration with potentially more content - maybe rename?
---
[GitHub] flink pull request #6340: [FLINK-9842][rest] Pass actual configuration to Bl...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6340#discussion_r202655858
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandlerTest.java ---
@@ -57,24 +60,39 @@
/**
* Tests for the {@link JobSubmitHandler}.
*/
+@RunWith(Parameterized.class)
public class JobSubmitHandlerTest extends TestLogger {
+ @Parameterized.Parameters(name = "SSL enabled: {0}")
+ public static Iterable<Boolean> data() {
+ return Arrays.asList(true, false);
+ }
+
@ClassRule
public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
- private static BlobServer blobServer;
- @BeforeClass
- public static void setup() throws IOException {
- Configuration config = new Configuration();
+ private final Configuration sslConfig;
--- End diff --
true, I'll give it a more generic name while merging.
---
[GitHub] flink pull request #6340: [FLINK-9842][rest] Pass actual configuration to Bl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6340
---