[GitHub] [airflow] houqp commented on a change in pull request #5731: [AIRFLOW-5117] support refreshing EKS api tokens

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #5731: [AIRFLOW-5117] support refreshing EKS api tokens
URL: https://github.com/apache/airflow/pull/5731#discussion_r313038378
 
 

 ##########
 File path: scripts/ci/pylint_todo.txt
 ##########
 @@ -201,6 +201,7 @@
 ./airflow/kubernetes/kubernetes_request_factory/kubernetes_request_factory.py
 ./airflow/kubernetes/kubernetes_request_factory/pod_request_factory.py
 ./airflow/kubernetes/kube_client.py
+./airflow/kubernetes/refresh_config.py
 
 Review comment:
   I initially tried fixing all the pylint errors, but the code turned to be much different than the original version. So I added it here to keep it similar to original k8s code to it's easier to compare with upstream code for further changes if needed. Turns out k8s python client doesn't pass our pylint rule ;)
   
   With that, do you still want me to fix all the pylint error? If so, I can throw in my original patches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services