[jira] [Commented] (PHOENIX-6120) Covered columns of indexes that have SINGLE_CELL_ARRAY_WITH_OFFSETS storage doesn't handle those columns

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193936#comment-17193936 ] 

Hadoop QA commented on PHOENIX-6120:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13011365/PHOENIX-6120.master.001.patch
  against master branch at commit .
  ATTACHMENT ID: 13011365

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        if (localIndex || transactionProvider != null || tableDDLOptions.contains("COLUMN_ENCODED_BYTES=0")) {
+        this.dataTableImmutableStorageScheme = dataTable.getImmutableStorageScheme() == null ? ImmutableStorageScheme.ONE_CELL_PER_COLUMN : dataTable.getImmutableStorageScheme();
+                        ImmutableBytesWritable dataValue = valueGetter.getLatestValue(dataColRef, ts);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.DropColumnIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OrphanViewToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexMaintenanceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexUsageIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT

     {color:red}-1 core zombie tests{color}.  There are 7 zombie test(s): 	at org.apache.phoenix.end2end.DeleteIT.testDeleteRowFromTableWithImmutableIndex(DeleteIT.java:520)
	at org.apache.phoenix.end2end.DeleteIT.testDeleteRowFromTableWithImmutableIndex(DeleteIT.java:393)
	at org.apache.phoenix.end2end.IndexToolForDeleteBeforeRebuildIT.testDeleteBeforeRebuildForGlobalIndex(IndexToolForDeleteBeforeRebuildIT.java:157)
	at org.apache.phoenix.end2end.EmptyColumnIT.testWhenTableWithIndexAndVariousOptions(EmptyColumnIT.java:492)

Test results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/83//testReport/
Code Coverage results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/83//artifact/phoenix-core/target/site/jacoco/index.html
Console output: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/83//console

This message is automatically generated.

> Covered columns of indexes that have SINGLE_CELL_ARRAY_WITH_OFFSETS storage doesn't handle those columns
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6120
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6120
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gokcen Iskender
>            Priority: Major
>         Attachments: PHOENIX-6120.master.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Repro:
>  # Create an index that has covered columns and the IMMUTABLE_STORAGE_SCHEME is SINGLE_CELL_ARRAY_WITH_OFFSETS
>  # Upsert rows to data table
>  # Query the covered column using index --> Null value is returned even though there is a value. 
> IndexMaintainer has a 4 year old code that doesn't return a value for covered columns,



--
This message was sent by Atlassian Jira
(v8.3.4#803005)