Re: [PR] 2.1.x [mina]

["mhitchens (via GitHub)" <gi...@apache.org>]

mhitchens commented on PR #28:
URL: https://github.com/apache/mina/pull/28#issuecomment-4566647022

   There's a regression in the patch that was pushed separately.
   
   https://github.com/apache/mina/commit/88cb55397c414c6d09ce2d085ce912ab4bf45bf3#diff-450772ac8848cc0e6cc29eef8dec7d3d2b5633a3f6f2c9f676169b3f73f28f6aR242
   
   This changes removeSessionBuffer() to use getAttribute instead of removeAttribute. After this call, the session will still have a reference to the buffer, and if it's a SimpleBuffer, it will not have been freed. This results in doDecode() re-decoding portions of the buffer.
   
   The patch on this pull request is correct, but this pull request was not what was merged.
   
   https://github.com/apache/mina/pull/28/changes/a8385aef3db4eb6d76504e31e14a3014195e137e#diff-450772ac8848cc0e6cc29eef8dec7d3d2b5633a3f6f2c9f676169b3f73f28f6aR240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org