You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 07:46:43 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #9375: Remove redundant code from breeze initialization

feluelle commented on a change in pull request #9375:
URL: https://github.com/apache/airflow/pull/9375#discussion_r442686418



##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -59,8 +59,6 @@ function initialize_common_environment {
     # Create useful directories if not yet created
     mkdir -p "${AIRFLOW_SOURCES}/.mypy_cache"
     mkdir -p "${AIRFLOW_SOURCES}/logs"
-    mkdir -p "${AIRFLOW_SOURCES}/tmp"

Review comment:
       But the two lines above do use the variables which will be exported. So I think it makes more sense to `mkdir` those directly. Otherwise there could be discrepancies between `TMP_DIR` and `${AIRFLOW_SOURCES}/tmp` for example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org