[jira] Commented: (SOLR-1682) Implement CollapseComponent

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885082#action_12885082 ] 

Martijn van Groningen commented on SOLR-1682:
---------------------------------------------

bq. I guess it depends... if this is the first phase only (just to find the top groups) then we don't really need the counts. If the collapse count is one... then we need to either fix the counts another way, and potentially provide an option to not return the counts.

If no counts are required then it would be optimal and fast. In the cases when the counts or any other aggregate statistics are necessary we would need to keep all the collapse groups in order to be accurate. Or give an option that the aggregate values are 'estimated', but all these variants can be different implementations. I think we should get at least one implementation ready (preferably the fast one) and the architecture for the different algorithms.

In the patches in SOLR-236 there is a notion of CollapseCollector, this accepts document ids that are collapsed  / grouped and are not returned to the regular result. Each implementation can do anything with this document id. For example to compute count, max, average or to keep to later return is collapsed document in the collapse response. How do you see that such a concept could be integrated into this patch? Or do you think its better to keep this functionality in the grouping implementations.

bq. There are other use cases where collapsed docs are more of an exception and the traditional single-doc-list would be better.
That is true, there are a lot of options to this to client in the response. 

> Implement CollapseComponent
> ---------------------------
>
>                 Key: SOLR-1682
>                 URL: https://issues.apache.org/jira/browse/SOLR-1682
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>            Reporter: Martijn van Groningen
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Next
>
>         Attachments: field-collapsing.patch, SOLR-1682.patch, SOLR-1682.patch, SOLR-1682_prototype.patch, SOLR-1682_prototype.patch, SOLR-236.patch
>
>
> Child issue of SOLR-236. This issue is dedicated to field collapsing in general and all its code (CollapseComponent, DocumentCollapsers and CollapseCollectors). The main goal is the finalize the request parameters and response format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org