[GitHub] [flink] pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #8361: [FLINK-12434][network] Replace listeners with CompletableFuture in InputGates
URL: https://github.com/apache/flink/pull/8361#discussion_r282102332
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
 ##########
 @@ -551,21 +551,20 @@ public void requestPartitions() throws IOException, InterruptedException {
 				}
 
 				currentChannel = inputChannelsWithData.remove();
-				enqueuedInputChannelsWithData.clear(currentChannel.getChannelIndex());
+
+				result = currentChannel.getNextBuffer();
+
+				if (result.isPresent() && result.get().moreAvailable()) {
+					// enqueue the currentChannel at the end to avoid starvation
 
 Review comment:
   But then we would have to duplicate the follow up code between this `if` and the end of the loop? Namely 
   ```
   				moreAvailable = !inputChannelsWithData.isEmpty();
   
   				if (!moreAvailable) {
   					resetIsAvailable();
   				}
   ```
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services