You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/20 16:14:37 UTC

[GitHub] [skywalking-nginx-lua] dmsolr opened a new pull request #79: introduce skywalking-eye to check license header

dmsolr opened a new pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] kezhenxu94 commented on pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79#issuecomment-823699321


   > Hi @wu-sheng @moonming , I notice that all files under `./lib/resty` are missing license header. I am not sure whether those are required to add license header.
   
   Files from 3rd-parties should be ignored in license-eyes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] dmsolr edited a comment on pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
dmsolr edited a comment on pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79#issuecomment-823417228


   Hi @wu-sheng @moonming , I notice that all files under `./lib/resty` are missing license header. I am not sure whether those are required to add license header.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] wu-sheng merged pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] dmsolr commented on pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79#issuecomment-823717844


   I got it. Thank both of you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] dmsolr commented on pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79#issuecomment-823417228


   Hi @wu-sheng @moonming , I notice that all files under `./lib` are missing license header. I am not sure whether those are required to add license header.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nginx-lua] wu-sheng commented on pull request #79: introduce skywalking-eye to check license header

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #79:
URL: https://github.com/apache/skywalking-nginx-lua/pull/79#issuecomment-823668758


   > I notice that all files under ./lib/resty are missing license header
   
   You could take a look at the LICENSE file, it is not written by us, so it is fine not having ASF header. We just copy them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org