You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/13 19:26:15 UTC

[GitHub] [pulsar] merlimat opened a new pull request #7524: Fix topic getting recreated immediately after deletion

merlimat opened a new pull request #7524:
URL: https://github.com/apache/pulsar/pull/7524


   ### Motivation
   
   There is a bug in the delete topic procedure that can trigger the topic re-creation immediately after it gets deleted.
   
   This can happen when the topic is not currently open. eg: 
    1. Request to delete the topic
    2. Namespace bundle is not owned
    3. Take ownership of bundle
    4. Start background loading of topics for the bundle
    5. Delete the topic
   
   If (5) finishes before (4), then the the can recreate a new topic with the old name.
   
   This bug is causing random failure on some of the tests like `NamespaceOwnershipListenerTests` where the namespace delete operation fails because "namespace is not empty" even though we just had deleted the only topic.
   
   ### Modifications
   
    * Pass a flag to avoid background topic loading for operations that just require to prove the ownership
    * Instead of passing N boolean flags, consolidated the args into a `LookupOptions` data class.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #7524: Fix topic getting recreated immediately after deletion

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7524:
URL: https://github.com/apache/pulsar/pull/7524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on pull request #7524: Fix topic getting recreated immediately after deletion

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7524:
URL: https://github.com/apache/pulsar/pull/7524#issuecomment-669147916


   Move to the pull request to 2.6.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org