You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2024/01/05 01:35:50 UTC
Change in asterixdb[master]: [ASTERIXDB-3337][COMP] setting size of join nodes
From <mu...@couchbase.com>:
murali.krishna@couchbase.com has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18029 )
Change subject: [ASTERIXDB-3337][COMP] setting size of join nodes
......................................................................
[ASTERIXDB-3337][COMP] setting size of join nodes
Change-Id: Ifd3bf37d50bec0900bd8956ee55b70c822854c04
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
3 files changed, 16 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/29/18029/1
diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
index 72d2caa..474e93e 100644
--- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
+++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java
@@ -701,8 +701,11 @@
jn.aliases.addAll(jnI.aliases);
jn.aliases.addAll(jnJ.aliases);
Collections.sort(jn.aliases);
- jn.size = jnI.size + jnJ.size;
+ jn.size = jnI.size + jnJ.size; // These are the original document sizes
jn.setCardinality(jn.computeJoinCardinality(), true);
+
+ //jn.setSizeVarsFromDisk(jnI.getSizeVarsFromDisk() + jnJ.getSizeVarsFromDisk()); This is not needed.
+ jn.setSizeVarsAfterScan(jnI.getSizeVarsAfterScan() + jnJ.getSizeVarsAfterScan());
} else {
addPlansToThisJn = jnNewBits.jnIndex;
}
diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
index 65a7fa8..1a1051d 100644
--- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
+++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java
@@ -1368,6 +1368,7 @@
public String toString() {
List<PlanNode> allPlans = joinEnum.getAllPlans();
StringBuilder sb = new StringBuilder(128);
+ sb.append("OutputSize(sizeVarsAfterScan) " + sizeVarsAfterScan);
if (IsBaseLevelJoinNode()) {
sb.append("Printing Scan Node ");
} else {
diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java
index bfc43fb..3fb8bfa 100644
--- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java
+++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/Stats.java
@@ -634,7 +634,7 @@
// This one gets the cardinality and also projection sizes
protected List<List<IAObject>> runSamplingQueryProjection(IOptimizationContext ctx, ILogicalOperator logOp,
int dataset, LogicalVariable primaryKey) throws AlgebricksException {
- LOGGER.info("***running sample query***");
+ LOGGER.info("***running complex sample query***");
IOptimizationContext newCtx = ctx.getOptimizationContextFactory().cloneOptimizationContext(ctx);
@@ -741,7 +741,7 @@
LOGGER.trace(viewInPlan);
}
- LOGGER.info("***returning from sample query***");
+ LOGGER.info("***returning from complex sample query***");
return AnalysisUtil.runQuery(Ref, Arrays.asList(newVar), newCtx, IRuleSetFactory.RuleSetKind.SAMPLING);
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18029
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ifd3bf37d50bec0900bd8956ee55b70c822854c04
Gerrit-Change-Number: 18029
Gerrit-PatchSet: 1
Gerrit-Owner: murali.krishna@couchbase.com
Gerrit-MessageType: newchange