You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Nicholas Jiang (Jira)" <ji...@apache.org> on 2021/01/31 09:11:00 UTC

[jira] [Commented] (FLINK-21210) ApplicationClusterEntryPoints should explicitly close PackagedProgram

    [ https://issues.apache.org/jira/browse/FLINK-21210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275812#comment-17275812 ] 

Nicholas Jiang commented on FLINK-21210:
----------------------------------------

[~chesnay], I have pushed a pull request for this simple issue. Could you please assgin this ticket to me? And If you are available, please help to review this pull request, thanks.

> ApplicationClusterEntryPoints should explicitly close PackagedProgram
> ---------------------------------------------------------------------
>
>                 Key: FLINK-21210
>                 URL: https://issues.apache.org/jira/browse/FLINK-21210
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available, starter
>             Fix For: 1.11.4, 1.12.2, 1.13.0
>
>
> FLINK-21164 introduced {{PackagedProgram#close}} to clean up temporary jars, and with FLINK-9844 the contained classloader will also be closed beforehand. This allows these files to be cleaned up properly.
> To make it obvious that this also happens in the application cluster entrypoints (and to reduce the chances of this potentially leaking code being copied elsewhere) we should adjust the entrypoints to explicitly close the \{{PackagedProgram}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)