[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5399: DATE_TIME should work as the primary time column for Pinot tables

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #5399:
URL: https://github.com/apache/incubator-pinot/pull/5399#discussion_r426197422



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/TimeFieldSpec.java
##########
@@ -28,6 +28,12 @@
 
 @SuppressWarnings("unused")
 @JsonIgnoreProperties(ignoreUnknown = true)
+@Deprecated
+/**
+ * TimeFieldSpec is deprecated. Use {@link DateTimeFieldSpec} instead.

Review comment:
       ```suggestion
    * @deprecated TimeFieldSpec is deprecated. Use {@link DateTimeFieldSpec} instead.
   ```

##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##########
@@ -507,10 +507,10 @@ public SchemaBuilder addMetric(String metricName, DataType dataType, Object defa
 
     /**
      * Add timeFieldSpec with incoming and outgoing granularity spec
-     * TODO: This is going to be deprecated in favor of addDateTime().
-     *  Many tests use this to construct Schema with TimeFieldSpec.
-     *  This will continue to exist for a while, as it helps to test backward compatibility of schemas containing TimeFieldSpec
+     * Deprecated in favor of addDateTime().

Review comment:
       ```suggestion
        * @deprecated in favor of {@link #addDateTime()}.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org