[GitHub] [arrow] maartenbreddels commented on a change in pull request #7357: ARROW-9100: [C++] Add ascii_lower kernel

[GitBox <gi...@apache.org>]

maartenbreddels commented on a change in pull request #7357:
URL: https://github.com/apache/arrow/pull/7357#discussion_r438713248



##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -48,6 +48,16 @@ struct AsciiUpper {
   }
 };
 
+struct AsciiLower {
+  template <typename... Ignored>
+  static std::string Call(KernelContext*, const util::string_view& val) {
+    std::string result = val.to_string();

Review comment:
       Yes, @xhochy and I discussed this above. The question is, do we want a few functions in, and then start iterating on a strategy (for ascii it's trivial, for utf8 less so), or not, I'm happy to explore different strategies first as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org