You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tomee.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/07 21:25:00 UTC

[jira] [Commented] (TOMEE-2337) Code cleanup: module openejb-loader

    [ https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713296#comment-16713296 ] 

ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------

GitHub user cicekhayri opened a pull request:

    https://github.com/apache/tomee/pull/262

    TOMEE-2337 - Code cleanup openejb container loader

    Added JavaDoc's, use diamond operator, isEmpty method, Switch case statement and added @Override 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cicekhayri/tomee code_cleanup_openejb_container_loader

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 298cdee7d52c9d048264d5e82558988e966413fe
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T20:38:07Z

    added JavaDoc and use of diamond operator

commit 0d70b3c3081704d9556eb7b10775c038a67fe869
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T20:52:37Z

    JavaDocs and use of isEmpty()

commit 5af81aa473c441fedd0aa0fee2d7e53264f33852
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T21:00:37Z

    JavaDoc added

commit 7ffcb01291a9cb369d1e5ddd1612bdf9f196698c
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T21:13:18Z

    JavaDoc and use of diamond operator

commit c4790232e257aba68e953ba923d8bda228d7db2c
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T21:16:38Z

    use isEmpty and added @Override

commit d815cee954f0deb03a831920d5f5047712f4f1a1
Author: Hayri Cicek <ha...@...>
Date:   2018-12-07T21:23:00Z

    update JavaDoc

----


> Code cleanup: module openejb-loader
> -----------------------------------
>
>                 Key: TOMEE-2337
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2337
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M1, 7.1.0
>            Reporter: Hayri Cicek
>            Priority: Trivial
>              Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)