You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2026/09/01 12:57:40 UTC
[PR] docs: document partition filter mapping [superset]
hughhhh opened a new pull request, #43760:
URL: https://github.com/apache/superset/pull/43760
### SUMMARY
Fourth of four. Documents partition filter mapping for admins: configuration, the operator matrix, and — deliberately — the parts a reader will reasonably assume the feature covers but it does not.
Two sections carry most of the weight:
**"Transform preserves ordering"** explains why the checkbox exists at all, with `hour()` as the worked example. It's a perfectly reasonable partition transform on a `TIMESTAMP` column, and mirroring a time range through it returns wrong numbers — `hour('2026-01-01 23:00')` is greater than `hour('2026-01-02 01:00')` even though the first instant is earlier.
**"The assumption this rests on"** states the invariant plainly. Superset emits a predicate on the partition column standing in for one on the mapped column, which is only valid if `partition_column = transform(mapped_column)` for every row. Superset cannot verify that — it's a property of whatever ETL populates the partition column — and when it breaks the result is quietly wrong charts rather than an error. The docs say so rather than letting people discover it.
Also documented as explicit non-coverage, because each one will otherwise surprise someone who expects "the dataset is now pruned": filter-value dropdowns don't prune, RLS predicates and custom SQL `WHERE` clauses don't mirror, and columns with an active advanced data type don't mirror.
`docs/static/feature-flags.json` was regenerated in PR 1, where the flag is introduced.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — docs only.
### TESTING INSTRUCTIONS
```bash
cd docs && npm run build
```
Or read `docs/admin_docs/configuration/partition-filter-mapping.mdx` directly. The page is picked up automatically by the auto-generated `configuration` sidebar.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: document partition filter mapping [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43760:
URL: https://github.com/apache/superset/pull/43760#issuecomment-5494377708
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 20fd771e4350f4dbdb1eaba728d43118f01ff286 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a96cbc43f85f60008d1222c |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43760--superset-docs-preview.netlify.app](https://deploy-preview-43760--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AsjNK0zOAQL8gLVfXRDclP7kYKJuSWpCTX-mZApQ3S7Q0S05KNjFOszBNMzMwMLBIMTQyMkpWqgUA) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43760--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: document partition filter mapping [superset]
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh commented on PR #43760:
URL: https://github.com/apache/superset/pull/43760#issuecomment-5545422938
Folding this into #43832 so the docs and the editor UI they describe ship together.
The docs commit (`20fd771`) is already in `hughhhh/pfm-5-editor-ui`'s history, so nothing is lost — #43832 now carries both, and its base moves to `hughhhh/pfm-3-preview-and-editor`.
The reason: this page instructs operators to pick a **Partition column** in the dataset editor and refers to "the editor's preview panel". Those controls land in #43832. Merging this first would publish instructions for controls that do not exist yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: document partition filter mapping [superset]
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh commented on PR #43760:
URL: https://github.com/apache/superset/pull/43760#issuecomment-5545441897
Correction to my note above: the combined PR is **#43891**, not #43832. GitHub will not let a PR that is part of a stack change its base, so #43832 was closed and reopened as #43891 against `hughhhh/pfm-3-preview-and-editor` — same branch, same commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: document partition filter mapping [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43760:
URL: https://github.com/apache/superset/pull/43760#issuecomment-5494293073
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: document partition filter mapping [superset]
Posted by "hughhhh (via GitHub)" <gi...@apache.org>.
hughhhh closed pull request #43760: docs: document partition filter mapping
URL: https://github.com/apache/superset/pull/43760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org