[jira] [Commented] (MINIFICPP-710) Fix errors in Property StringToInt conversion

["Mr TheSegfault (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16739911#comment-16739911 ] 

Mr TheSegfault commented on MINIFICPP-710:
------------------------------------------

I've made some comments on the PR. Some parts of it are welcome, but the part that's really a defect has been there a while and not something I wanted to solve in the work from August, but rather wanted to let 707 tease out and try to figure out how we stop - byte values from being set at all. I like the idea of fixing the issues above, but do you think we can do so while leaving the current way it works as-is? 

 

I've occasionally run into this with typos, and have always considered it a bug ( letting time period and data size values be set with invalid markers such as the negative sign. ). To open that discussion what do you think is the correct approach in these cases? 

> Fix errors in Property StringToInt conversion
> ---------------------------------------------
>
>                 Key: MINIFICPP-710
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-710
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Minor
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Property StringToInt conversion has some defects:
> -signed/unsigned assignment without checking limits
> -overflows



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)