You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2024/11/13 05:44:18 UTC

[PR] [core] Make FormatReaderFactory return FileRecordReader to reduce cast [paimon]

JingsongLi opened a new pull request, #4512:
URL: https://github.com/apache/paimon/pull/4512

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   In `ApplyBitmapIndexRecordReader` and `ApplyBitmapIndexRecordReader`, they will check the type of iterator which should be `FileRecordIterator`, it is always `FileRecordIterator`, and we should garrantee it by interface.
   
   So we let FormatReaderFactory return FileRecordReader, and all related readers should be `FileRecordReader`s.
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Make FormatReaderFactory return FileRecordReader to reduce cast [paimon]

Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin merged PR #4512:
URL: https://github.com/apache/paimon/pull/4512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org