You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by re...@apache.org on 2022/07/06 23:53:46 UTC

[cxf] branch main updated: Fixing cxf-rt-rs-extension-search test cases

This is an automated email from the ASF dual-hosted git repository.

reta pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cxf.git


The following commit(s) were added to refs/heads/main by this push:
     new b9569dad4a Fixing cxf-rt-rs-extension-search test cases
b9569dad4a is described below

commit b9569dad4a4636af572b23414a9ee8a67c2daee6
Author: Andriy Redko <dr...@gmail.com>
AuthorDate: Wed Jul 6 19:52:01 2022 -0400

    Fixing cxf-rt-rs-extension-search test cases
---
 .../ext/search/jpa/JPATypedQueryVisitorFiqlTest.java      | 15 +--------------
 .../ext/search/jpa/JPATypedQueryVisitorODataTest.java     | 15 +--------------
 2 files changed, 2 insertions(+), 28 deletions(-)

diff --git a/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorFiqlTest.java b/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorFiqlTest.java
index a5fe188397..4354681c7d 100644
--- a/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorFiqlTest.java
+++ b/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorFiqlTest.java
@@ -80,7 +80,7 @@ public class JPATypedQueryVisitorFiqlTest extends AbstractJPATypedQueryVisitorTe
     @Test
     public void testQueryCollection3() throws Exception {
         List<Book> books =
-            queryBooks("reviews.book.ownerInfo.name==Barry");
+            queryBooks("reviews.book.ownerInfo.name.name==Barry");
         assertEquals(1, books.size());
     }
 
@@ -271,19 +271,6 @@ public class JPATypedQueryVisitorFiqlTest extends AbstractJPATypedQueryVisitorTe
         assertEquals("Fred", book.getOwnerInfo().getName().getName());
     }
 
-
-    @Test
-    // "ownerInfo.name" maps to Name class and this
-    // does not work in OpenJPA, as opposed to Hibernate
-    // "ownerInfo.name.name" will map to primitive type, see
-    // testEqualsOwnerNameQuery3(), which also works in OpenJPA
-    public void testEqualsOwnerNameQuery2() throws Exception {
-        List<Book> books = queryBooks("ownerInfo.name==Fred");
-        assertEquals(1, books.size());
-        Book book = books.get(0);
-        assertEquals("Fred", book.getOwnerInfo().getName().getName());
-    }
-
     @Test
     public void testEqualsOwnerNameQuery3() throws Exception {
         List<Book> books = queryBooks("ownerName==Fred", null,
diff --git a/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorODataTest.java b/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorODataTest.java
index 1db9292b30..3c3e8b5472 100644
--- a/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorODataTest.java
+++ b/rt/rs/extensions/search/src/test/java/org/apache/cxf/jaxrs/ext/search/jpa/JPATypedQueryVisitorODataTest.java
@@ -72,7 +72,7 @@ public class JPATypedQueryVisitorODataTest extends AbstractJPATypedQueryVisitorT
     @Test
     public void testQueryCollection3() throws Exception {
         List<Book> books =
-            queryBooks("reviews.book.ownerInfo.name eq 'Barry'");
+            queryBooks("reviews.book.ownerInfo.name.name eq 'Barry'");
         assertEquals(1, books.size());
     }
 
@@ -234,19 +234,6 @@ public class JPATypedQueryVisitorODataTest extends AbstractJPATypedQueryVisitorT
         assertEquals("Fred", book.getOwnerInfo().getName().getName());
     }
 
-
-    @Test
-    // "ownerInfo.name" maps to Name class and this
-    // does not work in OpenJPA, as opposed to Hibernate
-    // "ownerInfo.name.name" will map to primitive type, see
-    // testEqualsOwnerNameQuery3(), which also works in OpenJPA
-    public void testEqualsOwnerNameQuery2() throws Exception {
-        List<Book> books = queryBooks("ownerInfo.name eq 'Fred'");
-        assertEquals(1, books.size());
-        Book book = books.get(0);
-        assertEquals("Fred", book.getOwnerInfo().getName().getName());
-    }
-
     @Test
     public void testEqualsOwnerNameQuery3() throws Exception {
         List<Book> books = queryBooks("ownerName eq 'Fred'", null,