Re: [PR] Correct aggregators violating names (druid)

["kgyrtkirk (via GitHub)" <gi...@apache.org>]

kgyrtkirk commented on code in PR #16615:
URL: https://github.com/apache/druid/pull/16615#discussion_r1644026933


##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -172,7 +172,9 @@ public static Windowing fromCalciteStuff(
             throw new CannotBuildQueryException(window, aggregateCall);

Review Comment:
   I wonder why didn't this check have failed if the agg column was renamed to `:agg` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org