You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Suraj Khurana <su...@hotwax.co> on 2020/07/29 15:53:00 UTC

ParameterNumber checkstyle rule

Hello team,

Currently there are around 175 issues due parameter count in java methods

Its default value is 7 [1], we should decide this configuration for
checkstyle. In current code, there are some methods having around 20
parameters (addOrIncreaseItem).

[1]:
https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html

Please share your thoughts on this.

--
Best Regards,
Suraj Khurana
Senior Technical Consultant

Re: ParameterNumber checkstyle rule

Posted by Suraj Khurana <su...@hotwax.co>.

Thanks Jacques.

10 looks good to me as well.

I have created a Jira and uploaded patch for this:
https://issues.apache.org/jira/browse/OFBIZ-11931

--
Best Regards,
Suraj Khurana
Senior Technical Consultant


On Thu, Jul 30, 2020 at 2:10 PM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> 10?
>
> Le 29/07/2020 à 17:53, Suraj Khurana a écrit :
> > Hello team,
> >
> > Currently there are around 175 issues due parameter count in java methods
> >
> > Its default value is 7 [1], we should decide this configuration for
> > checkstyle. In current code, there are some methods having around 20
> > parameters (addOrIncreaseItem).
> >
> > [1]:
> >
> https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html
> >
> > Please share your thoughts on this.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
>
>

Re: ParameterNumber checkstyle rule

Posted by Jacques Le Roux <ja...@les7arts.com>.

10?

Le 29/07/2020 à 17:53, Suraj Khurana a écrit :
> Hello team,
>
> Currently there are around 175 issues due parameter count in java methods
>
> Its default value is 7 [1], we should decide this configuration for
> checkstyle. In current code, there are some methods having around 20
> parameters (addOrIncreaseItem).
>
> [1]:
> https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html
>
> Please share your thoughts on this.
>
> --
> Best Regards,
> Suraj Khurana
> Senior Technical Consultant