[jira] [Commented] (CALCITE-1336) Add view name to the ViewExpander

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402794#comment-15402794 ] 

Julian Hyde commented on CALCITE-1336:
--------------------------------------

Yes, it's reasonable, but remember that in some contexts the view name is not available. In Calcite a view, like any Table, may be anonymous. It has a path only if it was acquired from the schema SPI.

Would it make sense to add the view name to the schema path? And let the schema path be null?

> Add view name to the ViewExpander
> ---------------------------------
>
>                 Key: CALCITE-1336
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1336
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Julien Le Dem
>            Assignee: Julian Hyde
>
> The ViewExpander.expandView() call already has the schema path that contains the view but not the view name itself.
> In some context it is useful to also know the name of the view being expanded.
> current call:
> {code}
> RelRoot expandView(
>         RelDataType rowType,
>         String queryString,
>         SchemaPlus rootSchema,
>         List<String> schemaPath);
> {code}
> proposed:
> {code}
> RelRoot expandView(
>         RelDataType rowType,
>         String queryString,
>         SchemaPlus rootSchema,
>         List<String> schemaPath,
>         String viewName);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)