[GitHub] [tinkerpop] FlorianHockmann commented on a change in pull request #1559: TINKERPOP-2682 Enable WS compression in .NET

[GitBox <gi...@apache.org>]

FlorianHockmann commented on a change in pull request #1559:
URL: https://github.com/apache/tinkerpop/pull/1559#discussion_r797348586



##########
File path: gremlin-dotnet/src/Gremlin.Net/Gremlin.Net.csproj
##########
@@ -67,14 +67,19 @@ NOTE that versions suffixed with "-rc" are considered release candidates (i.e. p
     <RepositoryUrl>https://github.com/apache/tinkerpop</RepositoryUrl>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>    
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
+    <EnablePackageValidation>true</EnablePackageValidation>
+    <PackageValidationBaselineVersion>3.5.2</PackageValidationBaselineVersion>

Review comment:
       When merging this to `master`, we'll have to see whether we already have additional breaking changes there. Then we can decide whether we want to change the baseline version there to `3.6.0` (as soon as that's released) to only check for breaking changes within the 3.6 line or keep it as is to check for breaking changes also between 3.6 and 3.5.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org