You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "Xuxiaotuan (via GitHub)" <gi...@apache.org> on 2024/02/25 09:09:41 UTC

[PR] [ISSUE-3472][Improve] Improve streampark-flink module based on [3.4 Collection Rule] [incubator-streampark]

Xuxiaotuan opened a new pull request, #3571:
URL: https://github.com/apache/incubator-streampark/pull/3571

   1. FOR`collection`returned values, unless there are special`concurrent`(such as thread safety), always return the`interface`, such as:
   returns List if use ArrayList
   
   3.Use isEmpty() instead of length() == 0 or size() == 0
   
   I didn't find this way of writing in the `streampark-flink` module.
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #3085  
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE-3085][Improve] Improve streampark-flink module based on [3.4 Collection Rule] [incubator-streampark]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai merged PR #3571:
URL: https://github.com/apache/incubator-streampark/pull/3571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE-3085][Improve] Improve streampark-flink module based on [3.4 Collection Rule] [incubator-streampark]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3571:
URL: https://github.com/apache/incubator-streampark/pull/3571#issuecomment-1963367952

   @Xuxiaotuan Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE-3085][Improve] Improve streampark-flink module based on [3.4 Collection Rule] [incubator-streampark]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3571:
URL: https://github.com/apache/incubator-streampark/pull/3571#issuecomment-1963196835

   If there are no comments by tomorrow I will start merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org