[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6813: [NIFI-11006] Upgraded from Junit4 to Junit5

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on code in PR #6813:
URL: https://github.com/apache/nifi/pull/6813#discussion_r1059619260


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/search/attributematchers/SearchableMatcherTest.java:
##########
@@ -25,14 +25,17 @@
 import org.apache.nifi.search.SearchContext;
 import org.apache.nifi.search.SearchResult;
 import org.apache.nifi.search.Searchable;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import org.mockito.Mock;
 import org.mockito.Mockito;
+import org.mockito.junit.jupiter.MockitoSettings;
+import org.mockito.quality.Strictness;
 
 import java.util.Collection;
 import java.util.HashSet;
 
+@MockitoSettings(strictness = Strictness.LENIENT)

Review Comment:
   There's a lot of `lenient` settings being used with Mockito, is this necessary for all the classes changed in this MR (whether as part of the `@MacktioSettings` annotation on a class or a `@Mock` annotation on a single bean)?
   
   The Mockito default is `strict` rather than `lenient` to try and encourage (what they believe to be) better testing practices, e.g. don't define unnecessary stubs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org