You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/24 18:22:37 UTC

[GitHub] [apisix-website] Yiyiyimu opened a new issue #352: use navbar_version instead of sidebar_version

Yiyiyimu opened a new issue #352:
URL: https://github.com/apache/apisix-website/issues/352


   So when users collapse the sidebar, they could still change doc versions. (And for me navbar version looks a bit nicer 🤣 
   
   **Actual Behaviour**
   
   ![image](https://user-images.githubusercontent.com/34589752/119389431-a047a480-bc99-11eb-8d2a-47c1b9e523d7.png)
   
   
   **Expected Behaviour**
   
   ![image](https://user-images.githubusercontent.com/34589752/119389471-ab023980-bc99-11eb-979c-20fbbbe19ecc.png)
   ![image](https://user-images.githubusercontent.com/34589752/119389480-b05f8400-bc99-11eb-8cc9-387db80576cf.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849236848


   > Just to make sure, the navbar version selector is globally? If we visit the homepage, will it appear?
   
   I think yes, see https://docusaurus.io/ and https://chaos-mesh.org/. But I'm not sure if it's configuratble


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh edited a comment on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

1502shivam-singh edited a comment on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-850857868


   Chiming in, `Navbar_version` on apisix-website would make sense, when it shows only when we are on a documentation page so we can traverse between versions, and hide it when we out of the docs and let the navbar stay as it's like on the current design.
   
   I feel doing this is possible, but hacky 😅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

1502shivam-singh commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-850857868


   Chiming in, `Navbar_version` on apisix-website would make sense, when it shows only when we are on a documentation page so we can traverse between versions, and hide it when we out of the docs and let the navbar stay as it's like on the current design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849267199


   We have multiple docs instance, not sure if it's configurable 🤣 What do you think? @qier222 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] iamayushdas commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

iamayushdas commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-871037355


   @Yiyiyimu I have personally worked on it before release, version selection in sidebar is far better option than in navbar, @qier222 has intelligently done it rightly, 
   adding that selector in navbar will ruin the look and feel of navbar, by making it crowded I guess, 
   
   do you agree Shuyang sir?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849224857


   Just to make sure, the navbar version selector is globally? If we visit the homepage, will it appear?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu closed issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

Yiyiyimu closed issue #352:
URL: https://github.com/apache/apisix-website/issues/352


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-871055074


   > adding that selector in navbar will ruin the look and feel of navbar, by making it crowded I guess
   
   Although I do not agree with this but it's more about personal favor, so close this issue since it's trivial.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] Yiyiyimu commented on issue #352: use navbar_version instead of sidebar_version

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on issue #352:
URL: https://github.com/apache/apisix-website/issues/352#issuecomment-849271421


   > We have multiple docs instance
   
   My bad I didn't realize this problem 🤣 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org