[GitHub] [airflow] baolsen commented on a change in pull request #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements

[GitBox <gi...@apache.org>]

baolsen commented on a change in pull request #6686: [AIRFLOW-6072] aws_hook: Outbound http proxy setting and other enhancements
URL: https://github.com/apache/airflow/pull/6686#discussion_r352059973
 
 

 ##########
 File path: airflow/contrib/hooks/aws_hook.py
 ##########
 @@ -18,79 +18,38 @@
 # under the License.
 
 """
-This module contains Base AWS Hook
+This module contains Base AWS Hook.
+
+.. seealso::
+    For more information on how to use this hook, take a look at the guide:
+    :ref:`howto/connection:AWSHook`
 """
 
 import configparser
 import logging
 
 import boto3
+from botocore.config import Config
 
 from airflow.exceptions import AirflowException
 from airflow.hooks.base_hook import BaseHook
 
 
-def _parse_s3_config(config_file_name, config_format='boto', profile=None):
 
 Review comment:
   Moved this function after the Class, so the documentation for actual AWS Hook is at the top of the page in Sphinx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services